commit d37af8dde96f1c091e908032c69e6e8d77a02319
Author: Jean-Marc Lasgouttes <[email protected]>
Date: Sun Aug 31 20:54:26 2025 +0200
Try to avoid Coverity Scan issue
Make the parameter defval of process_keyval_opt() a const reference to
solve coverity complaint about a useless copy.
---
src/tex2lyx/Preamble.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/tex2lyx/Preamble.cpp b/src/tex2lyx/Preamble.cpp
index 3fe436e011..3c5d998bd7 100644
--- a/src/tex2lyx/Preamble.cpp
+++ b/src/tex2lyx/Preamble.cpp
@@ -454,7 +454,7 @@ vector<string> split_options(string const & input)
* The found option is also removed from \p options.
*/
string process_keyval_opt(vector<string> & options, string const & name,
- string const defval = string())
+ string const & defval = empty_string())
{
for (size_t i = 0; i < options.size(); ++i) {
vector<string> option;
@@ -480,7 +480,7 @@ string const tripleToString(double const a, double const b,
double const c)
}
-string convert_color_value(string const & model, string const & value)
+string convert_color_value(string const & model, string const & value)
{
// we attempt to convert color values to rgb
// for the formulae, cf. the xcolor manual
--
lyx-cvs mailing list
[email protected]
https://lists.lyx.org/mailman/listinfo/lyx-cvs
