commit 7c4a0a2a4cf2c0d6dcce9e0d1cbe7b99e2f17fa9
Author: Jean-Marc Lasgouttes <[email protected]>
Date: Tue Jul 15 22:40:46 2025 +0200
Avoid some variables copying
These are 3 cases out of 31 Coverity scan issues. The others have been
ignored because they would imply an explicit std::move().
---
src/frontends/qt/ButtonController.cpp | 4 ++--
src/frontends/qt/GuiPrefs.cpp | 9 +++------
src/frontends/qt/GuiPrefs.h | 2 +-
3 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/src/frontends/qt/ButtonController.cpp
b/src/frontends/qt/ButtonController.cpp
index d059278a84..5c649e19df 100644
--- a/src/frontends/qt/ButtonController.cpp
+++ b/src/frontends/qt/ButtonController.cpp
@@ -40,7 +40,7 @@ class CheckedLineEdit
{
public:
CheckedLineEdit(QLineEdit * input, QWidget * label = nullptr,
- int tabindex = -1, QString const panel = QString());
+ int tabindex = -1, QString const & panel = QString());
/// check the widget and do visual marking
bool check() const;
/// reset all visual markings for tabs or panel sections
@@ -56,7 +56,7 @@ private:
CheckedLineEdit::CheckedLineEdit(QLineEdit * input, QWidget * label,
- int tabindex, QString const panel)
+ int tabindex, QString const & panel)
: input_(input), target_(label), tab_index_(tabindex),
panel_name_(panel)
{}
diff --git a/src/frontends/qt/GuiPrefs.cpp b/src/frontends/qt/GuiPrefs.cpp
index 82e41bf716..d93ce8dd81 100644
--- a/src/frontends/qt/GuiPrefs.cpp
+++ b/src/frontends/qt/GuiPrefs.cpp
@@ -1420,11 +1420,8 @@ void PrefColors::exportTheme()
FileDialog::Result result =
dialog.save((home_dir == "") ? "/" : home_dir,
{"*.theme", "*.*"},
theme_filename_);
- QString file_path;
- if (result.first == FileDialog::Chosen) {
- file_path = result.second;
- (saveExportThemeCommon(file_path));
- }
+ if (result.first == FileDialog::Chosen)
+ saveExportThemeCommon(result.second);
}
@@ -1950,7 +1947,7 @@ void PrefColors::filterByColor(const QColor &color)
}
-void PrefColors::filterCommon(const QList<QStandardItem *> items_found) const
+void PrefColors::filterCommon(QList<QStandardItem *> const & items_found) const
{
if (items_found.empty())
return;
diff --git a/src/frontends/qt/GuiPrefs.h b/src/frontends/qt/GuiPrefs.h
index 5972a58305..9a69b0ed46 100644
--- a/src/frontends/qt/GuiPrefs.h
+++ b/src/frontends/qt/GuiPrefs.h
@@ -356,7 +356,7 @@ private:
///
ColorPair toqcolor(ColorNamePair);
///
- void filterCommon(const QList<QStandardItem *> items_found) const;
+ void filterCommon(QList<QStandardItem *> const & items_found) const;
// Dictionary of theme names for translation purpose
// Add a system theme name here if you create a new one.
--
lyx-cvs mailing list
[email protected]
https://lists.lyx.org/mailman/listinfo/lyx-cvs
