[LyX/master] Fix two instances of Clang's -Wdouble-promotion

[Scott Kostyshak]

commit 59aa3e045ef017a578b3a64d2166fbb51c310f3e
Author: Scott Kostyshak <skost...@lyx.org>
Date:   Fri Jul 4 17:23:02 2025 +0200

    Fix two instances of Clang's -Wdouble-promotion
    
    src/frontends/qt/GuiView.cpp:184:30: warning: implicit conversion increases 
floating-point precision: 'float' to 'qreal' (aka 'double') [-Wdouble-promotion]
      184 |                 qreal locscale = htextsize.toFloat(&ok);
          |                       ~~~~~~~~   ~~~~~~~~~~^~~~~~~~~~~~
    
    src/frontends/qt/FancyLineEdit.cpp:344:22: warning: implicit conversion 
increases floating-point precision: 'float' to 'qreal' (aka 'double') 
[-Wdouble-promotion]
      344 |                 painter.setOpacity(m_iconOpacity);
          |                         ~~~~~~~~~~ ^~~~~~~~~~~~~
---
 src/frontends/qt/FancyLineEdit.h | 8 ++++----
 src/frontends/qt/GuiView.cpp     | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/frontends/qt/FancyLineEdit.h b/src/frontends/qt/FancyLineEdit.h
index 5d55640e95..5c76ca1d08 100644
--- a/src/frontends/qt/FancyLineEdit.h
+++ b/src/frontends/qt/FancyLineEdit.h
@@ -25,7 +25,7 @@ class FancyLineEditPrivate;
 class IconButton: public QAbstractButton
 {
        Q_OBJECT
-       Q_PROPERTY(float iconOpacity READ iconOpacity WRITE setIconOpacity)
+       Q_PROPERTY(qreal iconOpacity READ iconOpacity WRITE setIconOpacity)
        Q_PROPERTY(bool autoHide READ hasAutoHide WRITE setAutoHide)
        Q_PROPERTY(QPixmap pixmap READ pixmap WRITE setPixmap)
 public:
@@ -33,14 +33,14 @@ public:
        void paintEvent(QPaintEvent *event) override;
        void setPixmap(const QPixmap &pixmap) { m_pixmap = pixmap; update(); }
        QPixmap pixmap() const { return m_pixmap; }
-       float iconOpacity() { return m_iconOpacity; }
-       void setIconOpacity(float value) { m_iconOpacity = value; update(); }
+       qreal iconOpacity() { return m_iconOpacity; }
+       void setIconOpacity(qreal value) { m_iconOpacity = value; update(); }
        void animateShow(bool visible);
 
        void setAutoHide(bool hide) { m_autoHide = hide; }
        bool hasAutoHide() const { return m_autoHide; }
 private:
-       float m_iconOpacity;
+       qreal m_iconOpacity;
        bool m_autoHide;
        QPixmap m_pixmap;
 };
diff --git a/src/frontends/qt/GuiView.cpp b/src/frontends/qt/GuiView.cpp
index ae9602f1a0..777e825656 100644
--- a/src/frontends/qt/GuiView.cpp
+++ b/src/frontends/qt/GuiView.cpp
@@ -181,7 +181,7 @@ public:
                qreal const fsize = fontSize();
                bool ok;
                int hfsize = 20;
-               qreal locscale = htextsize.toFloat(&ok);
+               qreal locscale = htextsize.toDouble(&ok);
                if (!ok)
                        locscale = 1.0;
                QPointF const position = textPosition(false);
-- 
lyx-cvs mailing list
lyx-cvs@lists.lyx.org
https://lists.lyx.org/mailman/listinfo/lyx-cvs