commit f1e01dc0cf00e8865aa65584c573cce86ef86713 Author: Jean-Marc Lasgouttes <lasgout...@lyx.org> Date: Sat Mar 1 21:45:05 2025 +0100
Pass variable by reference to avoid copy (spotted by Coverity Scan) --- src/frontends/qt/ColorsCombo.cpp | 2 +- src/frontends/qt/ColorsCombo.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/frontends/qt/ColorsCombo.cpp b/src/frontends/qt/ColorsCombo.cpp index 1beeb4f201..734df200f8 100644 --- a/src/frontends/qt/ColorsCombo.cpp +++ b/src/frontends/qt/ColorsCombo.cpp @@ -101,7 +101,7 @@ void ColorsCombo::addItemSort(QString const & item, QString const & guiname, } -void ColorsCombo::setCustomColors(std::map<std::string, std::string> const custom_colors) +void ColorsCombo::setCustomColors(std::map<std::string, std::string> const & custom_colors) { custom_colors_ = custom_colors; fillComboColor(); diff --git a/src/frontends/qt/ColorsCombo.h b/src/frontends/qt/ColorsCombo.h index 88d3cafa2f..71f8f143c7 100644 --- a/src/frontends/qt/ColorsCombo.h +++ b/src/frontends/qt/ColorsCombo.h @@ -39,7 +39,7 @@ public: void addItemSort(QString const & item, QString const & guiname, QString const & category, QString color = QString()); /// Set BufferParams to access custom colors - void setCustomColors(std::map<std::string, std::string> const custom_colors); + void setCustomColors(std::map<std::string, std::string> const & custom_colors); /// Add "ignore" color entry? void hasIgnore(bool const b) { has_ignore_ = b; } /// Add "inherit" color entry? -- lyx-cvs mailing list lyx-cvs@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-cvs