commit eb4ff2a369fd0517c1f946e55f5c463ed621658a
Author: Jean-Marc Lasgouttes <[email protected]>
Date: Sun Feb 16 21:19:02 2025 +0100
Avoid copying menu definitions for no reason
When the menu did not exist (the common case), it makes no sense to
create the menu definition and then copy it to the menu tree.
Spotted by Coverity Scan.
---
src/frontends/qt/Menus.cpp | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/frontends/qt/Menus.cpp b/src/frontends/qt/Menus.cpp
index 5f7c8c3f98..d229e836a4 100644
--- a/src/frontends/qt/Menus.cpp
+++ b/src/frontends/qt/Menus.cpp
@@ -2688,13 +2688,10 @@ void Menus::read(Lexer & lex)
case md_menu: {
lex.next(true);
QString const name = toqstr(lex.getDocString());
- if (d->hasMenu(name))
- d->getMenu(name).read(lex);
- else {
- MenuDefinition menu(name);
- menu.read(lex);
- d->menulist_.push_back(menu);
- }
+ // Create a menu if it does not exist
+ if (!d->hasMenu(name))
+ d->menulist_.emplace_back(name);
+ d->getMenu(name).read(lex);
break;
}
case md_endmenuset:
--
lyx-cvs mailing list
[email protected]
https://lists.lyx.org/mailman/listinfo/lyx-cvs
