commit eef33de9670577f6e906ee23c757dab58bdcdf4c
Author: Jean-Marc Lasgouttes <[email protected]>
Date: Thu Feb 13 12:08:20 2025 +0100
avoid temporary variable (spotted by Coverity Scan)
---
src/Buffer.cpp | 9 ++++-----
src/insets/InsetBranch.h | 2 +-
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/Buffer.cpp b/src/Buffer.cpp
index d397c0ace5..72411ba4fe 100644
--- a/src/Buffer.cpp
+++ b/src/Buffer.cpp
@@ -3966,11 +3966,10 @@ void Buffer::getUsedBranches(std::list<docstring> &
result, bool const from_mast
for (Inset const & it : inset()) {
if (it.lyxCode() == BRANCH_CODE) {
InsetBranch const & br = static_cast<InsetBranch const
&>(it);
- docstring const name = br.branch();
- if (!from_master && !params().branchlist().find(name))
- result.push_back(name);
- else if (from_master &&
!masterBuffer()->params().branchlist().find(name))
- result.push_back(name);
+ if (!from_master &&
!params().branchlist().find(br.branch()))
+ result.push_back(br.branch());
+ else if (from_master &&
!masterBuffer()->params().branchlist().find(br.branch()))
+ result.push_back(br.branch());
continue;
}
if (it.lyxCode() == INCLUDE_CODE) {
diff --git a/src/insets/InsetBranch.h b/src/insets/InsetBranch.h
index 58154701e3..a1c0489583 100644
--- a/src/insets/InsetBranch.h
+++ b/src/insets/InsetBranch.h
@@ -53,7 +53,7 @@ public:
///
static void string2params(std::string const &, InsetBranchParams &);
///
- docstring branch() const { return params_.branch; }
+ docstring const & branch() const { return params_.branch; }
///
void rename(docstring const & newname) { params_.branch = newname; }
///
--
lyx-cvs mailing list
[email protected]
https://lists.lyx.org/mailman/listinfo/lyx-cvs
