commit 8778e76a9874b5c47d7c20567d625d06e02043e8
Author: Jean-Marc Lasgouttes <[email protected]>
Date:   Tue Sep 17 23:22:35 2019 +0200

    Pass some variables as reference
    
    Spotted by cppcheck.
---
 src/frontends/qt/GuiBibtex.cpp   |    2 +-
 src/frontends/qt/GuiBibtex.h     |    2 +-
 src/frontends/qt/GuiCitation.cpp |    4 ++--
 src/frontends/qt/GuiCitation.h   |    4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/frontends/qt/GuiBibtex.cpp b/src/frontends/qt/GuiBibtex.cpp
index 8414daa..897224c 100644
--- a/src/frontends/qt/GuiBibtex.cpp
+++ b/src/frontends/qt/GuiBibtex.cpp
@@ -520,7 +520,7 @@ vector<docstring> GuiBibtex::getFileEncodings()
 }
 
 
-void GuiBibtex::setFileEncodings(vector<docstring> const m)
+void GuiBibtex::setFileEncodings(vector<docstring> const & m)
 {
        for (docstring const & s: m) {
                docstring key;
diff --git a/src/frontends/qt/GuiBibtex.h b/src/frontends/qt/GuiBibtex.h
index 997902e..214ff85 100644
--- a/src/frontends/qt/GuiBibtex.h
+++ b/src/frontends/qt/GuiBibtex.h
@@ -88,7 +88,7 @@ private:
        ///
        std::vector<docstring> getFileEncodings();
        ///
-       void setFileEncodings(std::vector<docstring> const m);
+       void setFileEncodings(std::vector<docstring> const & m);
 
        ///
        bool initialiseParams(std::string const & data);
diff --git a/src/frontends/qt/GuiCitation.cpp b/src/frontends/qt/GuiCitation.cpp
index e561058..88a22fe 100644
--- a/src/frontends/qt/GuiCitation.cpp
+++ b/src/frontends/qt/GuiCitation.cpp
@@ -692,7 +692,7 @@ QStringList GuiCitation::selectedKeys()
 }
 
 
-void GuiCitation::setPreTexts(vector<docstring> const m)
+void GuiCitation::setPreTexts(vector<docstring> const & m)
 {
        // account for multiple use of the same keys
        QList<QModelIndex> handled;
@@ -731,7 +731,7 @@ vector<docstring> GuiCitation::getPreTexts()
 }
 
 
-void GuiCitation::setPostTexts(vector<docstring> const m)
+void GuiCitation::setPostTexts(vector<docstring> const & m)
 {
        // account for multiple use of the same keys
        QList<QModelIndex> handled;
diff --git a/src/frontends/qt/GuiCitation.h b/src/frontends/qt/GuiCitation.h
index 428ea50..d3a23b5 100644
--- a/src/frontends/qt/GuiCitation.h
+++ b/src/frontends/qt/GuiCitation.h
@@ -121,11 +121,11 @@ private:
        /// Get selected keys
        QStringList selectedKeys();
        /// Set pre texts of qualified lists
-       void setPreTexts(std::vector<docstring> const m);
+       void setPreTexts(std::vector<docstring> const & m);
        /// Get pre texts of qualified lists
        std::vector<docstring> getPreTexts();
        /// Set post texts of qualified lists
-       void setPostTexts(std::vector<docstring> const m);
+       void setPostTexts(std::vector<docstring> const & m);
        /// Get post texts of qualified lists
        std::vector<docstring> getPostTexts();
 

Reply via email to