commit ab6bd5e3190e61fa46eb2fd057cdf7f71faf3f38
Author: Juergen Spitzmueller <[email protected]>
Date: Wed Feb 21 10:17:10 2018 +0100
Fix list of viewable formats in view/update menu.
Also fix list in (currently unused) Export toolbar button.
Fixes: #11044
---
src/frontends/qt4/Menus.cpp | 2 +-
src/frontends/qt4/Toolbars.cpp | 10 +++++++---
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/frontends/qt4/Menus.cpp b/src/frontends/qt4/Menus.cpp
index eac4f57..6dd99ad 100644
--- a/src/frontends/qt4/Menus.cpp
+++ b/src/frontends/qt4/Menus.cpp
@@ -1123,7 +1123,7 @@ void MenuDefinition::expandFormats(MenuItem::Kind const
kind, Buffer const * buf
add(MenuItem(MenuItem::Command, toqstr(lbl),
FuncRequest(action)));
continue;
}
- // fall through
+ break;
case MenuItem::ExportFormats:
if (!f->inExportMenu())
continue;
diff --git a/src/frontends/qt4/Toolbars.cpp b/src/frontends/qt4/Toolbars.cpp
index 7678309..a2f8a0b 100644
--- a/src/frontends/qt4/Toolbars.cpp
+++ b/src/frontends/qt4/Toolbars.cpp
@@ -194,9 +194,13 @@ ToolbarInfo & ToolbarInfo::read(Lexer & lex)
case TO_IMPORTFORMATS:
case TO_UPDATEFORMATS:
case TO_VIEWFORMATS: {
- FormatList formats = (code == TO_IMPORTFORMATS) ?
- theConverters().importableFormats() :
- theConverters().exportableFormats(true);
+ FormatList formats;
+ if (code == TO_IMPORTFORMATS)
+ formats = theConverters().importableFormats();
+ else if (code == TO_EXPORTFORMATS)
+ formats =
theConverters().exportableFormats(false);
+ else
+ formats =
theConverters().exportableFormats(true);
sort(formats.begin(), formats.end());
for (Format const * f : formats) {
if (f->dummy())