[LyX/master] Properly fix #10863 compiler warnings.

[Richard Heck]

commit fab87917eab29ee0ac97808cc1f2292989a5156a
Author: Richard Heck <rgh...@lyx.org>
Date:   Sat Dec 16 09:30:12 2017 -0500

    Properly fix #10863 compiler warnings.
    
    Also change a few variable names, so as not to use "it" with
    range-based for loops.
---
 src/BufferParams.cpp         |    4 ++--
 src/insets/InsetCitation.cpp |    4 ++--
 src/mathed/InsetMathHull.cpp |    4 ++--
 src/mathed/MathParser.cpp    |    4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/BufferParams.cpp b/src/BufferParams.cpp
index 711f52f..8cb0c2c 100644
--- a/src/BufferParams.cpp
+++ b/src/BufferParams.cpp
@@ -2674,8 +2674,8 @@ OutputParams::FLAVOR BufferParams::getOutputFlavor(string 
const & format) const
                if (find(backs.begin(), backs.end(), dformat) == backs.end()) {
                        // Get shortest path to format
                        Graph::EdgePath path;
-                       for (auto const & bit : backs) {
-                               Graph::EdgePath p = 
theConverters().getPath(bit, dformat);
+                       for (auto const & bvar : backs) {
+                               Graph::EdgePath p = 
theConverters().getPath(bvar, dformat);
                                if (!p.empty() && (path.empty() || p.size() < 
path.size())) {
                                        path = p;
                                }
diff --git a/src/insets/InsetCitation.cpp b/src/insets/InsetCitation.cpp
index 236dda2..167fc24 100644
--- a/src/insets/InsetCitation.cpp
+++ b/src/insets/InsetCitation.cpp
@@ -253,8 +253,8 @@ docstring InsetCitation::toolTip(BufferView const & bv, 
int, int) const
        docstring tip;
        tip += "<ol>";
        int count = 0;
-       for (docstring const & kit : keys) {
-               docstring const key_info = bi.getInfo(kit, buffer(), ci);
+       for (docstring const & kvar : keys) {
+               docstring const key_info = bi.getInfo(kvar, buffer(), ci);
                // limit to reasonable size.
                if (count > 9 && keys.size() > 11) {
                        tip.push_back(0x2026);// HORIZONTAL ELLIPSIS
diff --git a/src/mathed/InsetMathHull.cpp b/src/mathed/InsetMathHull.cpp
index 724c115..06368ac 100644
--- a/src/mathed/InsetMathHull.cpp
+++ b/src/mathed/InsetMathHull.cpp
@@ -824,8 +824,8 @@ void InsetMathHull::preparePreview(DocIterator const & pos,
                usedMacros(cell(idx), pos, macros, defs);
 
        docstring macro_preamble;
-       for (auto const & defit : defs)
-               macro_preamble.append(defit);
+       for (auto const & defvar : defs)
+               macro_preamble.append(defvar);
 
        // set the font series and size for this snippet
        DocIterator dit = pos.getInnerText();
diff --git a/src/mathed/MathParser.cpp b/src/mathed/MathParser.cpp
index 35062ca..aaf8b22 100644
--- a/src/mathed/MathParser.cpp
+++ b/src/mathed/MathParser.cpp
@@ -745,7 +745,7 @@ docstring Parser::parse_verbatim_option()
        docstring res;
        if (nextToken().character() == '[') {
                Token t = getToken();
-               for (Token t = getToken(); t.character() != ']' && good(); t = 
getToken()) {
+               for (t = getToken(); t.character() != ']' && good(); t = 
getToken()) {
                        if (t.cat() == catBegin) {
                                putback();
                                res += '{' + parse_verbatim_item() + '}';
@@ -763,7 +763,7 @@ docstring Parser::parse_verbatim_item()
        docstring res;
        if (nextToken().cat() == catBegin) {
                Token t = getToken();
-               for (Token t = getToken(); t.cat() != catEnd && good(); t = 
getToken()) {
+               for (t = getToken(); t.cat() != catEnd && good(); t = 
getToken()) {
                        if (t.cat() == catBegin) {
                                putback();
                                res += '{' + parse_verbatim_item() + '}';