commit 7a0f7b7046a05bb006956c6f6e678069a0a2c24a
Author: Richard Heck <[email protected]>
Date:   Tue May 12 10:11:50 2015 -0400

    Pass XHTMLStream by reference. Problem found by coverity.
    
    The previous code worked because we are writing to the stream, and
    the actual odocstream is a member by reference of XHTMLStream.

diff --git a/src/insets/InsetTOC.cpp b/src/insets/InsetTOC.cpp
index fc1f42b..11662ce 100644
--- a/src/insets/InsetTOC.cpp
+++ b/src/insets/InsetTOC.cpp
@@ -148,7 +148,7 @@ void InsetTOC::makeTOCEntry(XHTMLStream & xs,
 }
 
 
-void InsetTOC::makeTOCWithDepth(XHTMLStream xs, 
+void InsetTOC::makeTOCWithDepth(XHTMLStream & xs, 
                Toc toc, OutputParams const & op) const
 {
        Toc::const_iterator it = toc.begin();
@@ -206,7 +206,7 @@ void InsetTOC::makeTOCWithDepth(XHTMLStream xs,
 }
 
 
-void InsetTOC::makeTOCNoDepth(XHTMLStream xs, 
+void InsetTOC::makeTOCNoDepth(XHTMLStream & xs, 
                Toc toc, const OutputParams & op) const
 {
        Toc::const_iterator it = toc.begin();
diff --git a/src/insets/InsetTOC.h b/src/insets/InsetTOC.h
index ead482b..1836836 100644
--- a/src/insets/InsetTOC.h
+++ b/src/insets/InsetTOC.h
@@ -64,9 +64,9 @@ public:
 
 private:
        ///
-       void makeTOCWithDepth(XHTMLStream xs, Toc toc, const OutputParams & op) 
const;
+       void makeTOCWithDepth(XHTMLStream & xs, Toc toc, const OutputParams & 
op) const;
        ///
-       void makeTOCNoDepth(XHTMLStream xs, Toc toc, const OutputParams & op) 
const;
+       void makeTOCNoDepth(XHTMLStream & xs, Toc toc, const OutputParams & op) 
const;
        ///
        void makeTOCEntry(XHTMLStream & xs, Paragraph const & par, OutputParams 
const & op) const;
        

Reply via email to