Quoting Dwight Engen (dwight.en...@oracle.com): > Hi Stéphane, > > I was able to add the ***containers output fairly in a fairly > straightforward manner. I also split out the patch into more discrete > logical changes, adding/refactoring the list.c test and fixing a leak in > list_active_containers() along the way. Serge, hopefully you don't mind > I renamed a couple of variables in there that were confusing me :) > > Out of curiosity, I'm wondering why we chose to use an array instead of > a list? I suppose its easier for the caller and it does make it easy > to use qsort, but OTOH I guess we could've done sorted inserts into a > list as well. I was thinking about realloc() with a large number of > containers being eventually slow, but I guess its only a bunch of > pointers so it won't ever be all that large of a chunk for realloc to > move. Anyway, its working fine right now.
I've got no attachment to the code :) If you think it'll be better as lists that's fine with me. ------------------------------------------------------------------------------ November Webinars for C, C++, Fortran Developers Accelerate application performance with scalable programming models. Explore techniques for threading, error checking, porting, and tuning. Get the most from the latest Intel processors and coprocessors. See abstracts and register http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk _______________________________________________ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
