Quoting Qiang Huang (h.huangqi...@huawei.com):
> ping.
> 
> Hi Serge or Stéphane,
> 
> What do you think about this patch?
> Spell error happens in our config file(many times for me :( ), and
> this error info will really save user's time to figure out the
> problem.
> 
> On 2013/9/16 10:04, Qiang Huang wrote:
> > When callback of one config line fail, we'd better give the exactly
> > info to help users locate the misconfig.
> > 
> > Signed-off-by: Qiang Huang <h.huangqi...@huawei.com>

I don't remember seeing this before.  Looks good, thanks.

Acked-by: Serge E. Hallyn <serge.hal...@ubuntu.com>

> > ---
> >  src/lxc/parse.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/src/lxc/parse.c b/src/lxc/parse.c
> > index 26cbbdd..dca808d 100644
> > --- a/src/lxc/parse.c
> > +++ b/src/lxc/parse.c
> > @@ -98,8 +98,10 @@ int lxc_file_for_each_line(const char *file, lxc_file_cb 
> > callback, void *data)
> > 
> >     while (getline(&line, &len, f) != -1) {
> >             err = callback(line, data);
> > -           if (err)
> > +           if (err) {
> > +                   ERROR("Failed to parse config: %s", line);
> >                     break;
> > +           }
> >     }
> > 
> >     if (line)
> > 
> 
> 

------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. 
http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk
_______________________________________________
Lxc-devel mailing list
Lxc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxc-devel

Reply via email to