Quoting Dwight Engen (dwight.en...@oracle.com): > On Fri, 20 Sep 2013 14:48:40 -0500 > Serge Hallyn <serge.hal...@ubuntu.com> wrote: > > > These might be a bit controversial. The process lock was held > > for some long periods of time for tweaking consoles. These > > can deadlock with some of lock holds I introduced recently. I > > would argue that if two threads are fighting over the console, > > you're gonna have trouble anyway, and the process locks here > > weren't saving us from anything. If we want to do a console > > Are we sure we can walk/modify the lxc_ttys list lockless? I agree
Yeah we do need to lock those. But I don't think there's a rush for it. > threaded console use is "interesting", but I don't think we want list > corruption. Of course we don't want deadlocks either :) So which do you think would be better - introduce a lxc_ttys lock specifically, or introduce a general 'console' mutex which is taken any time we open a console or edit the lxc_ttys? -serge ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
