On Mon, Sep 09, 2013 at 03:35:52PM -0500, Serge Hallyn wrote: > We log that at INFO level in case it is needed. However, in a modern > kernel a container which was shut down using 'shutdown' will always > have been signaled with SIGINT. Making lxc-start return an error to > reflect that seems overkill. > > It's *conceivable* that someone is depending on this behavior, so I'm > sending this out for anyone to NACK, but if I hear no complaints I'll > apply. > > Signed-off-by: Serge Hallyn <serge.hal...@ubuntu.com>
I think it's reasonable to assume that we have more users on kernels
supporting the cleaner shutdown mechanism than people depending on the
hold behaviour.
Acked-by: Stéphane Graber <stgra...@ubuntu.com>
> ---
> src/lxc/error.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/lxc/error.c b/src/lxc/error.c
> index 15e6ab0..46c34bb 100644
> --- a/src/lxc/error.c
> +++ b/src/lxc/error.c
> @@ -50,7 +50,6 @@ extern int lxc_error_set_and_log(int pid, int status)
>
> if (WIFSIGNALED(status)) {
> int signal = WTERMSIG(status);
> - ret = ret + 128 + signal;
>
> INFO("child <%d> ended on signal (%d)", pid, signal);
> }
> --
> 1.8.3.2
>
>
> ------------------------------------------------------------------------------
> Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
> Discover the easy way to master current and previous Microsoft technologies
> and advance your career. Get an incredible 1,500+ hours of step-by-step
> tutorial videos with LearnDevNow. Subscribe today and save!
> http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
> _______________________________________________
> Lxc-devel mailing list
> Lxc-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/lxc-devel
--
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
