On Thu, Jul 11, 2013 at 09:22:47AM -0500, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > To add to the "you broke my lxc-create" list, the new version also > > dropped the fancy header I introduced a while back (showing the template > > name, the arguments passed to it and the checksum of the template used > > at the time. > > > > An example was: > > # Template used to create this container: ubuntu > > # Parameters passed to the template: -a amd64 -r precise > > # Template script checksum (SHA-1): b1f15036868c53cca0698f1efcadd88dfefaee9b > > So as it stands, when you clone a container etc the comments > get dropped. When you use the API to add a config item and > rewrite it, you lose comments. > > How should we handle this? > > One thing we could do is have 'lxc.header' and 'lxc.footer' > statements which are ignored like comments but which get > reinserted whenever we write out the config. > > Or, we could simply have the lxcapi_create() function manually > prepend your fancy header as the very last thing it does, and > keep everything else the same. > > Preference? > > -serge
It's true that we loose any comment with save_config() and that's fine as people calling this through the API aren't too likely to actually read the file by hand anyway. My problem is the regression on initial config file creation where we still get the layout and comments inserted by the template but no longer have the header. So I think it'd be good enough to have this header generated and prepended only when the config file is first created (initial lxcapi_create()) (which I believe is the second option your proposed). -- Stéphane Graber Ubuntu developer http://www.ubuntu.com
signature.asc
Description: Digital signature
------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
