On 01/11/2013 11:17 PM, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): >> The previous implementation of the openpty check was always returning >> 'no' as openpty is typically defined in util. >> >> Signed-off-by: Stéphane Graber <stgra...@ubuntu.com> > > But if I read the docs right > (http://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Libraries.html) > this will cause HAVE_LIBUTIL to be set... not HAVE_OPENPTY. > > is that what you want? (or did I misread the docs?)
The AC_CHECK_LIB call is only there to make the subsequent AC_CHECK_FUNCS call succeed for openpty. That seemed a little weird to me too, but that's what http://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Generic-Functions.html says you should do... >> --- >> configure.ac | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/configure.ac b/configure.ac >> index dd50701..d1f5ad9 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -227,6 +227,7 @@ AC_CHECK_HEADERS([sys/signalfd.h pty.h sys/capability.h >> sys/personality.h utmpx. >> AC_CHECK_FUNCS([setns pivot_root sethostname unshare]) >> >> # Check for some functions >> +AC_CHECK_LIB(util, openpty) >> AC_CHECK_FUNCS([openpty hasmntopt setmntent endmntent]) >> AC_CHECK_FUNCS([getline], >> AM_CONDITIONAL(HAVE_GETLINE, true) >> -- >> 1.8.0 >> >> >> ------------------------------------------------------------------------------ >> Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and >> much more. Get web development skills now with LearnDevNow - >> 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts. >> SALE $99.99 this month only -- learn more at: >> http://p.sf.net/sfu/learnmore_122812 >> _______________________________________________ >> Lxc-devel mailing list >> Lxc-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122912
_______________________________________________ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
