----- On Jan 6, 2020, at 8:58 PM, Benjamin Poirier benjamin.poir...@gmail.com wrote:
> On 2020/01/06 09:39, Mathieu Desnoyers wrote: >> ----- On Jan 6, 2020, at 12:19 AM, Benjamin Poirier >> benjamin.poir...@gmail.com >> wrote: >> >> > INADDR_ANY is 0.0.0.0 >> >> Hi Benjamin, >> >> Double-checking this seems to confirm what the man page states: >> >> % lttng-relayd -b >> % netstat -lnp | grep lttng-relayd >> tcp 0 0 0.0.0.0:5342 0.0.0.0:* LISTEN >> 4445/lttng-relayd >> tcp 0 0 0.0.0.0:5343 0.0.0.0:* LISTEN >> 4445/lttng-relayd >> tcp 0 0 127.0.0.1:5344 0.0.0.0:* LISTEN >> 4445/lttng-relayd >> unix 2 [ ACC ] STREAM LISTENING 56508 4445/lttng-relayd >> /home/compudj/.lttng/relayd/health-4445 >> >> Based on this output, the "live" port of the relayd daemon appears to be >> listening >> only on 127.0.0.1 by default. > > That's right but not relevant to this patch. The part of the man page > changed by this patch is not stating the defaults. > >> >> What makes you think the man page needs to be updated ? > > The part of the man page changed by this patch is: > If a user is within a secured network and/or has proper firewall > settings, lttng-relayd can listen to LTTng live connections from > all network interfaces by specifying > --live-port=tcp://localhost:5344. > > That is incorrect. To listen for connections to all addresses on the host, > the socket has to be bound to INADDR_ANY, 0.0.0.0. Oh! Good point. I was missing the context. Yes this change makes sense. Acked-by: Mathieu Desnoyers <mathieu.desnoy...@efficios.com> Jérémie is on vacation this week, so we can expect it to be merged somewhere next week. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
