> @@ -168,8 +187,7 @@ skip $isroot "Root access is needed to set bandwith 
> limits. Skipping all tests."
>  {
>  
>       # Catch sigint and try to cleanup limits
> -     trap interrupt_cleanup SIGTERM
> -     trap interrupt_cleanup SIGINT
> +     trap interrupt_cleanup SIGTERM SIGINT
>  
>       BW_LIMITS=(3200 1600 800 400 200 100 50 25)
>       for BW in ${BW_LIMITS[@]};
> @@ -177,6 +195,7 @@ skip $isroot "Root access is needed to set bandwith 
> limits. Skipping all tests."
>               diag "Test high-throughput with bandwidth limit set to 
> ${BW}kbits"
>  
>               set_bw_limit $BW
> +             ok $? "Setting bandwidth limit"

In case of failure here we should force a reset since it could lead to long
timeout/hang depending on which tc command failed?

This could also be done inside set_bw_limit at each stage.

>  
>               start_lttng_sessiond
>               start_lttng_relayd "-o $TRACE_PATH"
> @@ -185,5 +204,6 @@ skip $isroot "Root access is needed to set bandwith 
> limits. Skipping all tests."
>               stop_lttng_relayd
>               stop_lttng_sessiond
>               reset_bw_limit
> +             ok $? "Reset bandwith limits"
>       done
>  }
> -- 
> 2.11.0
> 

-- 
Jonathan Rajotte-Julien
EfficiOS
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Reply via email to