Good point, although the fix is not the one you proposed. See upstream commit:
commit 9a3bb76ad636d5b5904e611ee8b4553d900a807c Author: Mathieu Desnoyers <[email protected]> Date: Fri Feb 22 15:26:47 2013 -0500 Fix: ctf-text: don't close stdout Signed-off-by: Mathieu Desnoyers <[email protected]> Thanks, Mathieu * Thibault, Daniel ([email protected]) wrote: > The verbose output of babeltrace (-v, --verbose) is missing its closing > comment. Looking at babeltrace.c, line 670: > > fmt_write->close_trace(td_write); > > bt_context_put(ctx); > printf_verbose("finished converting. Output written to:\n%s\n", > opt_output_path ? : "<stdout>"); > goto end; > > I suspect that the printf_verbose should be moved to *before* the > fmt_write->close_trace. That way the last comment would be sent to stdout > (or the user-selected --output, once bug 459 > (http://bugs.lttng.org/issues/459) is fixed), right? > > Daniel U. Thibault > R & D pour la défense Canada - Valcartier (RDDC Valcartier) / Defence R&D > Canada - Valcartier (DRDC Valcartier) > Cyber sécurité pour les missions essentielles (CME) / Mission Critical Cyber > Security (MCCS) > Protection des systèmes et contremesures (PSC) / Systems Protection & > Countermeasures (SPC) > 2459 route de la Bravoure > Québec, QC G3J 1X5 > CANADA > Vox : (418) 844-4000 x4245 > Fax : (418) 844-4538 > NAC : 918V QSDJ <http://www.travelgis.com/map.asp?addr=918V%20QSDJ> > Gouvernement du Canada / Government of Canada > <http://www.valcartier.drdc-rddc.gc.ca/> > > _______________________________________________ > lttng-dev mailing list > [email protected] > http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
