Hi Rob,
On 12/06/2020 11:21, Rob Wilton (rwilton) wrote:
Hi Peter,
Cutting the response to just the text in question.
-----Original Message-----
From: Peter Psenak <[email protected]>
Sent: 12 June 2020 09:25
To: Rob Wilton (rwilton) <[email protected]>; Alvaro Retana
<[email protected]>
Cc: Acee Lindem (acee) <[email protected]>; draft-ietf-ospf-te-link-attr-
[email protected]; [email protected]; [email protected]; Yingzhen Qu
<[email protected]>; The IESG <[email protected]>
Subject: Re: Robert Wilton's Discuss on draft-ietf-ospf-te-link-attr-
reuse-14: (with DISCUSS)
Hi Rob,
Probably this paragraph could be improved to make its intent more clear?
I.e. the attributes values in the default ASLA apply for all applications,
unless that are overridden by application specific definitions of
particular attributes, and all other default attribute value still apply.
##PP
ok, I see.
What about this:
If link attributes are advertised associated with zero length
Application Identifier Bit Masks for both standard applications and
user defined applications, then any Standard Application and/or any
User Defined Application is permitted to use that set of link
attributes. If support for a new application is introduced
on any node in a network in the presence of such advertisements,
these advertisements are permitted to be used by the new application.
If this is not what is intended, then existing advertisements MUST be
readvertised with an explicit set of applications specified before a
new application is introduced.
An application specific advertisement (Application Identifier Bit
Mask with a matching Application Identifier Bit set) for an attribute
MUST always be preferred over the advertisement of the same attribute
with the zero length Application Identifier Bit Masks for both
standard applications and user defined applications on the same link.
thanks,
Peter
[RW]
This is okay, but could potentially still be improved by giving a name to the
wildcard attributes (e.g. wildcard, common, or default). Possibly splitting
the text regarding new applications from the preceding part of the paragraph
would help. I would then also reorder the paragraphs. Perhaps something along
the lines of:
Wildcard link attributes can be advertised using zero length
Application Identifier Bit Masks for both standard applications and
user defined applications. All Standard and User Defined
Applications are permitted to use any of the wildcard link attributes.
An application specific advertisement (Application Identifier Bit
Mask with a matching Application Identifier Bit set) for a link
Attribute MUST always be preferred over any wildcard advertisement of
the link attribute on the same link.
If support for a new application is introduced on any node in a
network in the presence of wildcard advertisements, these wildcard
advertisements are permitted to be used by the new application.
If this is not what is intended, then existing advertisements MUST be
re-advertised with an explicit set of applications specified before
the new application is introduced.
If you prefer your proposed text, or want to wordsmith my proposed text that is
fine with me ...
One further comment: I presume that it is allowed to split the advertisement of wildcard link attributes into multiple ASLA TLVs, as long as they don't overlap.
sure.
I don't think that you need to say anything about this, unless my presumption
is wrong.
I don't see a need to say anything about that.
thanks,
Peter
Regards,
Rob
_______________________________________________
Lsr mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/lsr
