Phil created LOGBACK-1326: ----------------------------- Summary: Allow LayoutWrappingEncoder to have a parent of a type other than Appender Key: LOGBACK-1326 URL: https://jira.qos.ch/browse/LOGBACK-1326 Project: logback Issue Type: Bug Components: logback-core Affects Versions: 1.2.3, 1.2.2, 1.2.1, 1.3.0 Reporter: Phil Assignee: Logback dev list
A backwards incompatible change was introduced in 1.2.1 that forced {{LayoutWrapperEncoder}} to only be able to have a parent of type {{Appender}}. Specifically, [this change|https://github.com/qos-ch/logback/commit/d3d704c12e7b8e6503187744ac2200c244088c63] This [broke functionality in downstream projects|https://github.com/logstash/logstash-logback-encoder/issues/232] that allow an encoder to be embedded with another encoder (specifically for prefix/suffix support). It would be great if {{LayoutWrappingEncoder.setParent}} was changed to allow an {{Encoder}} or {{Appender}} as a parent, so that downstream projects can continue to allow encoders within other encoders. I have submitted [PR #383|https://github.com/qos-ch/logback/pull/383] to allow this. -- This message was sent by Atlassian JIRA (v7.3.1#73012) _______________________________________________ logback-dev mailing list logback-dev@qos.ch http://mailman.qos.ch/mailman/listinfo/logback-dev