Re: [llvm-commits] [llvm-gcc-4.2] r46039 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Anton Korobeynikov]

Hello, Bill

> +    if (BigEndian == FLOAT_WORDS_BIG_ENDIAN) {
> +      UArr[0] = RealArr[0];   // Long -> int convert
> +      UArr[1] = RealArr[1];
> +    } else {
> +      UArr[0] = RealArr[1];   // Long -> int convert
> +      UArr[1] = RealArr[0];
> +    }
> +
Why don't do just something like this:
    UArr[0] = RealArr[0];   // Long -> int convert
    UArr[1] = RealArr[1];

    if (BigEndian == FLOAT_WORDS_BIG_ENDIAN)
      std::swap(UArr[0], UArr[1]);

This looks to me pretty much readable.
-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits