On Jan 14, 2008, at 12:56 AM, Alain Frisch wrote: > Hello, > > Sorry for not replying before. I was not subscribed to llvm-commits > and did not see your email. > >> A couple of comments: You really need to add some comments in >> Makefile.config.in over the stuff that sets SYSPATH to indicate >> what it is used for, and probably over the TableGen = ... line in >> Makefile.rules. If you don't do this, someone may break this in >> the future. > > Ok, done. > >> Another thing: does it work to add something like this to >> makefile.rules? >> ifeq ($(OS),Cygwin) >> USE_CYGPATH := true # Actually, it would be better to do the >> syspath stuff here and remove USE_CYGPATH >> endif > > cygpath should only be used when compiling for Mingw under Cygwin > (ie, the gcc -mno-cygwin). I've done that instead:
Okay, this looks really good. One final question before I commit: why does tblgen want a windows path instead of a unix path? Can that be fixed in tblgen? Doesn't this affect llvm-as and all other tools? -Chris _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
