Hi Chris,

> byval makes sense semantically for any pointer to sized type, I think  
> it would be reasonable to expand it to allow any of these pointers,  
> including the one above.

I adjusted the check to allow pointers to arrays, but got a crash in
SelectionDAGISel.cpp:

        if (F.paramHasAttr(j, ParamAttr::ByVal)) {
          Flags |= ISD::ParamFlags::ByVal;
          const PointerType *Ty = cast<PointerType>(I->getType());
          const StructType *STy = cast<StructType>(Ty->getElementType()); <== 
HERE

Ciao,

Duncan.
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Reply via email to