Author: lattner Date: Fri Dec 28 18:59:12 2007 New Revision: 45392 URL: http://llvm.org/viewvc/llvm-project?rev=45392&view=rev Log: dead calls to llvm.stacksave can be deleted, even though they have potential side-effects.
Modified: llvm/trunk/lib/Transforms/Utils/Local.cpp llvm/trunk/test/Transforms/InstCombine/deadcode.ll Modified: llvm/trunk/lib/Transforms/Utils/Local.cpp URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/Local.cpp?rev=45392&r1=45391&r2=45392&view=diff ============================================================================== --- llvm/trunk/lib/Transforms/Utils/Local.cpp (original) +++ llvm/trunk/lib/Transforms/Utils/Local.cpp Fri Dec 28 18:59:12 2007 @@ -17,6 +17,7 @@ #include "llvm/DerivedTypes.h" #include "llvm/Instructions.h" #include "llvm/Intrinsics.h" +#include "llvm/IntrinsicInst.h" #include "llvm/Analysis/ConstantFolding.h" #include "llvm/Target/TargetData.h" #include "llvm/Support/GetElementPtrTypeIterator.h" @@ -173,8 +174,16 @@ bool llvm::isInstructionTriviallyDead(Instruction *I) { if (!I->use_empty() || isa<TerminatorInst>(I)) return false; - if (!I->mayWriteToMemory()) return true; + if (!I->mayWriteToMemory()) + return true; + // Special case intrinsics that "may write to memory" but can be deleted when + // dead. + if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(I)) + // Safe to delete llvm.stacksave if dead. + if (II->getIntrinsicID() == Intrinsic::stacksave) + return true; + return false; } Modified: llvm/trunk/test/Transforms/InstCombine/deadcode.ll URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/deadcode.ll?rev=45392&r1=45391&r2=45392&view=diff ============================================================================== --- llvm/trunk/test/Transforms/InstCombine/deadcode.ll (original) +++ llvm/trunk/test/Transforms/InstCombine/deadcode.ll Fri Dec 28 18:59:12 2007 @@ -1,4 +1,5 @@ ; RUN: llvm-as < %s | opt -instcombine | llvm-dis | grep {ret i32 %A} +; RUN: llvm-as < %s | opt -die | llvm-dis | not grep call.*llvm.stacksave define i32 @test(i32 %A) { %X = or i1 false, false @@ -12,3 +13,12 @@ %C.upgrd.1 = phi i32 [ %B, %T ], [ %A, %0 ] ret i32 %C.upgrd.1 } + +define i32* @test2(i32 %width) { + %tmp = call i8* @llvm.stacksave( ) + %tmp14 = alloca i32, i32 %width + ret i32* %tmp14 +} + +declare i8* @llvm.stacksave() + _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits