Re: [llvm-commits] [llvm-gcc-4.2] r44891 - in /llvm-gcc-4.2/trunk/gcc: llvm-backend.cpp testsuite/g++.dg/init/llvm-convert-1.C

[Duncan Sands]

Hi Devang,

> Do not emit pending decls twice.
...
> --- llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp (original)
> +++ llvm-gcc-4.2/trunk/gcc/llvm-backend.cpp Tue Dec 11 17:17:57 2007
> @@ -897,7 +897,8 @@
>    }
>    
>    if (TheDebugInfo) TheDebugInfo->EmitGlobalVariable(GV, decl); 
> -  
> +
> +  TREE_ASM_WRITTEN(decl) = 1;
>    timevar_pop(TV_LLVM_GLOBALS);
>  }

at the start of the function there is:

void emit_global_to_llvm(tree decl) {
  if (errorcount || sorrycount) return;

Should this be
  if (errorcount || sorrycount) {
    TREE_ASM_WRITTEN(fndecl) = 1;
    return;  // Do not process broken code.
  }
like in llvm_emit_code_for_current_function?
And if so, maybe it should be like that too
in emit_alias_to_llvm.  What do you think?

Ciao,

Duncan.
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits