On Dec 2, 2007, at 3:07 AM, pawel kunio wrote: > Hello, > Here comes the more or less final and complete version of patch for > PR889. The coding standard > enforced by Chris. I added the asserts as checks for Value-inherited > classes without destroyThis. > Should it be accepted, please submit as it seems, I havent got the > proper rights to do so.
I'm getting a bunch of errors and warnings of this sort: llvm/Instructions.h:2206: warning: 'class llvm::FPToUIInst' has virtual functions but non-virtual destructor llvm/Instructions.h:2258: error: a class-key must be used when declaring a friend llvm/Instructions.h:2258: error: friend declaration does not name a class or function llvm/Instructions.h:2250: warning: 'class llvm::FPToSIInst' has virtual functions but non-virtual destructor llvm/Instructions.h:2302: error: a class-key must be used when declaring a friend llvm/Instructions.h:2302: error: friend declaration does not name a class or function llvm/Instructions.h:2294: warning: 'class llvm::IntToPtrInst' has virtual functions but non-virtual destruct To work around the first one, please mark value's dtor virtual temporarily. To fix the others, please use "friend class foo" instead of "friend foo". -Chris _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
