On Aug 2, 2007, at 2:34 PM, David A. Greene wrote:
> On Wednesday 01 August 2007 08:49, Gordon Henriksen wrote:
>
>> Can't you just use
>>
>> Value* Args[] = { CI->GetOperand(1),
>> CI->GetOperand(2) };
>> CallInst *NC = new CallInst(GCRead, Args, Args + 2,
>> CI->getName(), CI);
>>
>> here and in UpgradeParser.y?
>
> Yep. Do people prefer that? I'll change it if so.
Yes please. SmallVector's are still variable sized (like
std::vector) so they have a slight amount of overhead compared to
arrays. If you can use a fixed-size array, they are better.
Thanks David,
-Chris
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
