Author: djg
Date: Wed Jul 25 14:33:14 2007
New Revision: 40487
URL: http://llvm.org/viewvc/llvm-project?rev=40487&view=rev
Log:
Don't ignore the return value of AsmPrinter::doInitialization and
AsmPrinter::doFinalization.
Modified:
llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp
llvm/trunk/lib/Target/Alpha/AlphaAsmPrinter.cpp
llvm/trunk/lib/Target/IA64/IA64AsmPrinter.cpp
llvm/trunk/lib/Target/Mips/MipsAsmPrinter.cpp
llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp
llvm/trunk/lib/Target/Sparc/SparcAsmPrinter.cpp
llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp
llvm/trunk/lib/Target/X86/X86IntelAsmPrinter.cpp
Modified: llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp
URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp?rev=40487&r1=40486&r2=40487&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/ARM/ARMAsmPrinter.cpp Wed Jul 25 14:33:14 2007
@@ -789,13 +789,13 @@
// Emit initial debug information.
DW.BeginModule(&M);
- AsmPrinter::doInitialization(M);
+ bool Result = AsmPrinter::doInitialization(M);
// Darwin wants symbols to be quoted if they have complex names.
if (Subtarget->isTargetDarwin())
Mang->setUseQuotes(true);
- return false;
+ return Result;
}
bool ARMAsmPrinter::doFinalization(Module &M) {
@@ -1024,6 +1024,5 @@
DW.EndModule();
}
- AsmPrinter::doFinalization(M);
- return false; // success
+ return AsmPrinter::doFinalization(M);
}
Modified: llvm/trunk/lib/Target/Alpha/AlphaAsmPrinter.cpp
URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Alpha/AlphaAsmPrinter.cpp?rev=40487&r1=40486&r2=40487&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Alpha/AlphaAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/Alpha/AlphaAsmPrinter.cpp Wed Jul 25 14:33:14 2007
@@ -198,8 +198,7 @@
else
O << "\t.arch ev6\n";
O << "\t.set noat\n";
- AsmPrinter::doInitialization(M);
- return false;
+ return AsmPrinter::doInitialization(M);
}
bool AlphaAsmPrinter::doFinalization(Module &M) {
@@ -271,8 +270,7 @@
O << '\n';
}
- AsmPrinter::doFinalization(M);
- return false;
+ return AsmPrinter::doFinalization(M);
}
/// PrintAsmOperand - Print out an operand for an inline asm expression.
Modified: llvm/trunk/lib/Target/IA64/IA64AsmPrinter.cpp
URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/IA64/IA64AsmPrinter.cpp?rev=40487&r1=40486&r2=40487&view=diff
==============================================================================
--- llvm/trunk/lib/Target/IA64/IA64AsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/IA64/IA64AsmPrinter.cpp Wed Jul 25 14:33:14 2007
@@ -248,13 +248,13 @@
}
bool IA64AsmPrinter::doInitialization(Module &M) {
- AsmPrinter::doInitialization(M);
+ bool Result = AsmPrinter::doInitialization(M);
O << "\n.ident \"LLVM-ia64\"\n\n"
<< "\t.psr lsb\n" // should be "msb" on HP-UX, for starters
<< "\t.radix C\n"
<< "\t.psr abi64\n"; // we only support 64 bits for now
- return false;
+ return Result;
}
bool IA64AsmPrinter::doFinalization(Module &M) {
@@ -344,8 +344,7 @@
}
O << "\n\n";
- AsmPrinter::doFinalization(M);
- return false; // success
+ return AsmPrinter::doFinalization(M);
}
/// createIA64CodePrinterPass - Returns a pass that prints the IA64
Modified: llvm/trunk/lib/Target/Mips/MipsAsmPrinter.cpp
URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsAsmPrinter.cpp?rev=40487&r1=40486&r2=40487&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/MipsAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/Mips/MipsAsmPrinter.cpp Wed Jul 25 14:33:14 2007
@@ -428,6 +428,5 @@
}
}
- AsmPrinter::doFinalization(M);
- return false; // success
+ return AsmPrinter::doFinalization(M);
}
Modified: llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp
URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp?rev=40487&r1=40486&r2=40487&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp Wed Jul 25 14:33:14 2007
@@ -626,7 +626,7 @@
}
bool LinuxAsmPrinter::doInitialization(Module &M) {
- AsmPrinter::doInitialization(M);
+ bool Result = AsmPrinter::doInitialization(M);
// GNU as handles section names wrapped in quotes
Mang->setUseQuotes(true);
@@ -635,7 +635,7 @@
// Emit initial debug information.
DW.BeginModule(&M);
- return false;
+ return Result;
}
bool LinuxAsmPrinter::doFinalization(Module &M) {
@@ -743,8 +743,7 @@
// Emit initial debug information.
DW.EndModule();
- AsmPrinter::doFinalization(M);
- return false; // success
+ return AsmPrinter::doFinalization(M);
}
std::string LinuxAsmPrinter::getSectionForFunction(const Function &F) const {
@@ -858,7 +857,7 @@
assert(Directive <= PPC::DIR_64 && "Directive out of range.");
O << "\t.machine " << CPUDirectives[Directive] << "\n";
- AsmPrinter::doInitialization(M);
+ bool Result = AsmPrinter::doInitialization(M);
// Darwin wants symbols to be quoted if they have complex names.
Mang->setUseQuotes(true);
@@ -878,7 +877,7 @@
// Emit initial debug information.
DW.BeginModule(&M);
- return false;
+ return Result;
}
bool DarwinAsmPrinter::doFinalization(Module &M) {
@@ -1078,8 +1077,7 @@
// code that does this, it is always safe to set.
O << "\t.subsections_via_symbols\n";
- AsmPrinter::doFinalization(M);
- return false; // success
+ return AsmPrinter::doFinalization(M);
}
Modified: llvm/trunk/lib/Target/Sparc/SparcAsmPrinter.cpp
URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Sparc/SparcAsmPrinter.cpp?rev=40487&r1=40486&r2=40487&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Sparc/SparcAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/Sparc/SparcAsmPrinter.cpp Wed Jul 25 14:33:14 2007
@@ -286,6 +286,5 @@
}
}
- AsmPrinter::doFinalization(M);
- return false; // success
+ return AsmPrinter::doFinalization(M);
}
Modified: llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp
URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp?rev=40487&r1=40486&r2=40487&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86AsmPrinter.cpp Wed Jul 25 14:33:14 2007
@@ -120,13 +120,13 @@
DW.BeginModule(&M);
}
- AsmPrinter::doInitialization(M);
+ bool Result = AsmPrinter::doInitialization(M);
// Darwin wants symbols to be quoted if they have complex names.
if (Subtarget->isTargetDarwin())
Mang->setUseQuotes(true);
- return false;
+ return Result;
}
bool X86SharedAsmPrinter::doFinalization(Module &M) {
@@ -389,8 +389,7 @@
DW.EndModule();
}
- AsmPrinter::doFinalization(M);
- return false; // success
+ return AsmPrinter::doFinalization(M);
}
/// createX86CodePrinterPass - Returns a pass that prints the X86 assembly code
Modified: llvm/trunk/lib/Target/X86/X86IntelAsmPrinter.cpp
URL:
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86IntelAsmPrinter.cpp?rev=40487&r1=40486&r2=40487&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86IntelAsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86IntelAsmPrinter.cpp Wed Jul 25 14:33:14 2007
@@ -339,7 +339,7 @@
}
bool X86IntelAsmPrinter::doInitialization(Module &M) {
- X86SharedAsmPrinter::doInitialization(M);
+ bool Result = X86SharedAsmPrinter::doInitialization(M);
Mang->markCharUnacceptable('.');
@@ -373,7 +373,7 @@
}
}
- return false;
+ return Result;
}
bool X86IntelAsmPrinter::doFinalization(Module &M) {
@@ -463,10 +463,10 @@
}
// Bypass X86SharedAsmPrinter::doFinalization().
- AsmPrinter::doFinalization(M);
+ bool Result = AsmPrinter::doFinalization(M);
SwitchToDataSection("");
O << "\tend\n";
- return false; // success
+ return Result;
}
void X86IntelAsmPrinter::EmitString(const ConstantArray *CVA) const {
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
