Hi Raul,
Good first step! Thanks.
+bool ARMTargetMachine::addCodeEmitter(FunctionPassManager &PM, bool
Fast,
+ MachineCodeEmitter &MCE) {
+ // FIXME: Move this to TargetJITInfo!
+ setRelocationModel(Reloc::Static);
+
+ setCodeModel(CodeModel::Large);
+
+ // Machine code emitter pass for ARM.
+ PM.add(createARMCodeEmitterPass(*this, MCE));
+ return false;
+}
The setCodeModel() call is unnecessary.
Please don't include header files if they are not necessary. For
example, is it necessary to include TargetOptions.h in
ARMCodeEmitter.cpp
Also in ARMCodeEmitter.cpp:
void Emitter::emitInstruction(const MachineInstr &MI) {
NumEmitted++; // Keep track of the # of mi's emitted
}
Please remove the blank line. :-)
ARMJITInfo.h:
// This file contains the ARM implementation of the TargetJITInfo class.
Not accurate. Something like "This file contains the declaration of
the ARMJITInfo class." (I'll fix the similar problems in other
targets. :-)
Can you fix the problems and resubmit the patch? BTW, I can't patch
cleanly:
Patching file lib/Target/ARM/ARMTargetMachine.cpp using Plan A...
Hunk #1 succeeded at 33.
patch: **** malformed patch at line 90: @@ -106,3 +129,22 @@
Please fix that as well.
Thanks,
Evan
On Jun 27, 2007, at 11:26 AM, Raul Fernandes Herbster wrote:
This is an initial implementation of ARM JIT support. So far, it
hasn't generated code machine yet. Next patch must provide such
feature. The tar.gz file must be unpacked under lib/Target/ARM
directory. Please, send me any feedback.
Best regards, Raul.
--
Raul Fernandes Herbster
Embedded and Pervasive Computing Laboratory - embedded.dee.ufcg.edu.br
Electrical Engineering Department - DEE - www.dee.ufcg.edu.br
Electrical Engineering and Informatics Center - CEEI
Federal University of Campina Grande - UFCG - www.ufcg.edu.br
Caixa Postal 10105
58109-970 Campina Grande - PB - Brasil
<arm_jit_patch>
<arm_jit.tar.gz>
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
