On Jun 15, 2007, at 10:01 AM, Duncan Sands wrote:

Seems fine to me, minor comments:

How about this?  [I had to make the critical edge detection
less conservative after finding a testcase in which some
critical edges were not empty].

Ciao,

Duncan.
<eh_hack.diff>

Ah, another minor simplification:

+/// isFilterOrSelector - Return true if this instruction is a call to the
+/// eh.filter or the eh.selector intrinsic.
+static bool isFilterOrSelector(Instruction *I) {
  if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(I))
    return II->getIntrinsicID() == Intrinsic::eh_selector
      || II->getIntrinsicID() == Intrinsic::eh_filter;
  return false;
}

Otherwise, looks great, please apply,

-Chris
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Reply via email to