On May 16, 2007, at 11:21 AM, Evan Cheng wrote: >> I realized this morning what I really meant :). I think that >> isPredicable should be a non-virtual function that checks TID- >>> Flags&M_PREDICATED (Actually, it might make sense to introduce a >> new M_PREDICABLE flag). Further, the default implementation of >> TII::PredicateInstruction should work for all standard instructions, >> but should remain virtual. > > That's fine. They just won't be inlined or else it would cause cyclic > dependencies between libraries.
What do you mean? Shouldn't it be just like TII::isCommutableInstr but checking a different flag? > So isPredicable won't be very fast. Even if not inlined, non-virtual is faster than virtual. -Chris _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
