On Mar 29, 2007, at 9:31 PM, Zhou Sheng wrote:
> 在 2007-03-29四的 21:02 -0700，Chris Lattner写道：
>>> + /// This function will return true iff this constant represents
>>> a value with
>>> + /// active bits bigger than 64 bits or a value greater than the
>>> given uint64_t
>>> + /// value.
>>> + /// @returns true iff this constant is greater or equal to the
>>> given number.
>>> + /// @brief Determine if the value is greater or equal to the
>>> given number.
>>> + bool greaterOrEqual(uint64_t Num) {
>>> + return Val.getActiveBits() > 64 || Val.getZExtValue() > Num;
>>
>> Shouldn't the second one be >= ?
> Yes, i'll correct that.
>
>
>>
>> Can you please rename this greaterOrEqualUnsigned or even
>> compare_gtu
>> (N)?
> How about "bool compare_uge(uint64_t Num)" ?
Sounds great. I prefer that to just uge since ConstantInt has a lot
of other methods,
Thanks!
-Chris
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
