On Mar 10, 2007, at 8:50 AM, Nick Lewycky wrote:
>
>> + struct CaseRange {
>> + Constant* Low;
>> + Constant* High;
>> + BasicBlock* BB;
>> +
>> + CaseRange(Constant* _Low = NULL, Constant* _High = NULL,
>> + BasicBlock* _BB = NULL):
>> + Low(_Low), High(_High), BB(_BB) { }
>> + };
>
> Do you ever store non-ConstantInt in Low and High? If not, could you
> either replace this with, or make it a wrapper around ConstantRange?
I agree. Among other things, this means that you'll be using APInt's
instead of Constant*'s. APInt's are more efficient to manipulate.
Thanks,
-Chris
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
