>> I strongly encourage Sheng to do instcombine one piece at a time: say >> visitAND, then visitOR (etc) and submit them as separate patches. > > I have requested that he submit daily (if not more frequent) patches.
Thanks! >> Blasting me with one huge patch is not going to earn brownie points, >> and if/when it breaks something, it won't be easy to track down what >> part of the huge change did it. > > Yes, I'm well aware of that. And its not just you. I will review > each of > these patches before you ever see it. Great! -Chris _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits