On Wed, 2007-02-21 at 00:23 -0600, Chris Lattner wrote: > > Changes in directory llvm: > > Makefile updated: 1.69 -> 1.70 > --- > Log message: > > revert r1.68. This breaks 'make install' without doing 'make' first, but > fixes PR1208: http://llvm.org/PR1208 .
This isn't correct. I implemented the NO_INSTALL keyword specifically to prevent installation of a directory's build products. This is what utils/TableGen does. Please revert this patch (1.70) and edit the examples directory's makefiles to include: NO_INSTALL := 1 That will prevent installation of the examples while still fixing the PR for allowing "make install" to build everything and install only that which is installable. >From the makefile guide: > NO_INSTALL > Specifies that the build products of the directory should not > be installed but should be built even if the install target is > given. This is handy for directories that build libraries or > tools that are only used as part of the build process, such as > code generators (e.g. tblgen). Thanks, Reid. > > > --- > Diffs of the changes: (+7 -0) > > Makefile | 7 +++++++ > 1 files changed, 7 insertions(+) > > > Index: llvm/Makefile > diff -u llvm/Makefile:1.69 llvm/Makefile:1.70 > --- llvm/Makefile:1.69 Mon Feb 5 17:18:58 2007 > +++ llvm/Makefile Wed Feb 21 00:23:20 2007 > @@ -40,6 +40,13 @@ > OPTIONAL_DIRS := > endif > > +# Don't install utils, examples, or projects they are only used to > +# build LLVM. > +ifeq ($(MAKECMDGOALS),install) > + DIRS := $(filter-out utils, $(DIRS)) > + OPTIONAL_DIRS := > +endif > + > # Include the main makefile machinery. > include $(LLVM_SRC_ROOT)/Makefile.rules > > > > > _______________________________________________ > llvm-commits mailing list > llvm-commits@cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
