Changes in directory llvm/lib/VMCore:
AsmWriter.cpp updated: 1.238 -> 1.239 --- Log message: Remove a bunch of complex logic that is completely dead: duplicates can never be inserted! --- Diffs of the changes: (+1 -57) AsmWriter.cpp | 58 +--------------------------------------------------------- 1 files changed, 1 insertion(+), 57 deletions(-) Index: llvm/lib/VMCore/AsmWriter.cpp diff -u llvm/lib/VMCore/AsmWriter.cpp:1.238 llvm/lib/VMCore/AsmWriter.cpp:1.239 --- llvm/lib/VMCore/AsmWriter.cpp:1.238 Tue Jan 9 01:55:49 2007 +++ llvm/lib/VMCore/AsmWriter.cpp Tue Jan 9 01:58:11 2007 @@ -1539,20 +1539,6 @@ /// CreateModuleSlot - Insert the specified GlobalValue* into the slot table. void SlotMachine::CreateModuleSlot(const GlobalValue *V) { - assert(!V->hasName() && "Doesn't need a slot!"); - const Type *VTy = V->getType(); - - // Look up the type plane for the Value's type from the module map - TypedPlanes::const_iterator MI = mMap.find(VTy); - - // If the module map's type plane is not for the Value's type - if (MI != mMap.end()) { - // Lookup the value in the module's map - ValueMap::const_iterator MVI = MI->second.map.find(V); - if (MVI != MI->second.map.end()) - return; - } - return insertValue(V); } @@ -1561,49 +1547,7 @@ void SlotMachine::CreateFunctionSlot(const Value *V) { const Type *VTy = V->getType(); assert(VTy != Type::VoidTy && !V->hasName() && "Doesn't need a slot!"); - assert(!isa<Constant>(V) && "Can't insert a Constants into SlotMachine"); - - // Look up the type plane for the Value's type from the module map - TypedPlanes::const_iterator MI = mMap.find(VTy); - - // Get the type plane for the Value's type from the function map - TypedPlanes::const_iterator FI = fMap.find(VTy); - // If there is a corresponding type plane in the function map - if (FI != fMap.end()) { - // Lookup the Value in the function map. - ValueMap::const_iterator FVI = FI->second.map.find(V); - // If the value exists in the function map, we're done. - if (FVI != FI->second.map.end()) - return; - - // If there is no corresponding type plane in the module map - if (MI == mMap.end()) - return insertValue(V); - // Look up the value in the module map - ValueMap::const_iterator MVI = MI->second.map.find(V); - // If we found it, it was already inserted - if (MVI != MI->second.map.end()) - return; - return insertValue(V); - } - - // Otherwise, there is no corresponding type plane in the function map yet. - - // If the type plane doesn't exists at the module level - if (MI == mMap.end()) { - return insertValue(V); - // else type plane exists at the module level, examine it - } else { - // Look up the value in the module's map - ValueMap::const_iterator MVI = MI->second.map.find(V); - // If we didn't find it there either - if (MVI == MI->second.map.end()) - // Return the slot number as the module's contribution to - // the type plane plus the index of the function map insertion. - return insertValue(V); - else - return; - } + return insertValue(V); } _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits