Jim,

Don't commit that!

These patches are intertwined. After everything is reviewed, I'll submit
the whole thing as one patch.  If you commit this, it will break on
i386.

Reid.

On Wed, 2006-12-20 at 17:43 -0800, Chris Lattner wrote:
> On Dec 20, 2006, at 4:46 PM, Reid Spencer wrote:
> 
> > Attached is a patch for the gcc/config/rs6000/rs6000.h file to remove
> > isSigned() calls. This is analgous to the last patch I sent but for  
> > PPC
> > instead of X86.  Same comments
> > apply.
> >
> > This patch has not been compiled or tested as I don't have a PPC
> > machine. Please review and try it.
> 
> This patch looks fine to me.
> 
> Jim, please check that it works (e.g. by making a testcase that uses  
> the modified instructions) and commit it if it looks good to you,
> 
> Thanks,
> 
> -Chris
> 

_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Reply via email to