Changes in directory llvm/lib/Target/X86:
X86FloatingPoint.cpp updated: 1.58 -> 1.59 --- Log message: Revert. This wasn't meant to be checked in. --- Diffs of the changes: (+18 -11) X86FloatingPoint.cpp | 29 ++++++++++++++++++----------- 1 files changed, 18 insertions(+), 11 deletions(-) Index: llvm/lib/Target/X86/X86FloatingPoint.cpp diff -u llvm/lib/Target/X86/X86FloatingPoint.cpp:1.58 llvm/lib/Target/X86/X86FloatingPoint.cpp:1.59 --- llvm/lib/Target/X86/X86FloatingPoint.cpp:1.58 Mon Nov 13 17:36:35 2006 +++ llvm/lib/Target/X86/X86FloatingPoint.cpp Tue Nov 14 13:20:33 2006 @@ -40,7 +40,6 @@ #include "llvm/Support/Debug.h" #include "llvm/Support/Compiler.h" #include "llvm/ADT/DepthFirstIterator.h" -#include "llvm/ADT/SmallVector.h" #include "llvm/ADT/Statistic.h" #include "llvm/ADT/STLExtras.h" #include <algorithm> @@ -214,12 +213,20 @@ // Get dead variables list now because the MI pointer may be deleted as part // of processing! - SmallVector<unsigned, 8> DeadRegs; - for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) { - const MachineOperand &MO = MI->getOperand(i); - if (MO.isReg() && MO.isDead()) - DeadRegs.push_back(MO.getReg()); - } + LiveVariables::killed_iterator IB, IE; + tie(IB, IE) = LV->dead_range(MI); + + DEBUG( + const MRegisterInfo *MRI = MF.getTarget().getRegisterInfo(); + LiveVariables::killed_iterator I = LV->killed_begin(MI); + LiveVariables::killed_iterator E = LV->killed_end(MI); + if (I != E) { + std::cerr << "Killed Operands:"; + for (; I != E; ++I) + std::cerr << " %" << MRI->getName(*I); + std::cerr << "\n"; + } + ); switch (Flags & X86II::FPTypeMask) { case X86II::ZeroArgFP: handleZeroArgFP(I); break; @@ -234,8 +241,8 @@ // Check to see if any of the values defined by this instruction are dead // after definition. If so, pop them. - for (unsigned i = 0, e = DeadRegs.size(); i != e; ++i) { - unsigned Reg = DeadRegs[i]; + for (; IB != IE; ++IB) { + unsigned Reg = *IB; if (Reg >= X86::FP0 && Reg <= X86::FP6) { DEBUG(std::cerr << "Register FP#" << Reg-X86::FP0 << " is dead!\n"); freeStackSlotAfter(I, Reg-X86::FP0); @@ -755,7 +762,6 @@ unsigned Op0 = getFPReg(MI->getOperand(0)); unsigned Op1 = getFPReg(MI->getOperand(2)); - bool KillsOp1 = LV->KillsRegister(MI, X86::FP0+Op1); // The first operand *must* be on the top of the stack. moveToTop(Op0, I); @@ -767,8 +773,9 @@ MI->getOperand(0).setReg(getSTReg(Op1)); MI->setOpcode(getConcreteOpcode(MI->getOpcode())); + // If we kill the second operand, make sure to pop it from the stack. - if (Op0 != Op1 && KillsOp1) { + if (Op0 != Op1 && LV->KillsRegister(MI, X86::FP0+Op1)) { // Get this value off of the register stack. freeStackSlotAfter(I, Op1); } _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits