On Oct 17, 2006, at 7:28 PM, Reid Spencer wrote:
>> Index: llvm/lib/AsmParser/llvmAsmParser.y
>> diff -u llvm/lib/AsmParser/llvmAsmParser.y:1.265 llvm/lib/
>> AsmParser/llvmAsmParser.y:1.266
>> --- llvm/lib/AsmParser/llvmAsmParser.y:1.265 Sun Oct 15 18:26:46 2006
>> +++ llvm/lib/AsmParser/llvmAsmParser.y Tue Oct 17 21:19:55 2006
>> @@ -1068,6 +1068,7 @@
>> %token DEPLIBS CALL TAIL ASM_TOK MODULE SIDEEFFECT
>> %token CC_TOK CCC_TOK CSRETCC_TOK FASTCC_TOK COLDCC_TOK
>> %token X86_STDCALLCC_TOK X86_FASTCALLCC_TOK
>> +%token DATA
>
> The word "Data" is somewhat bland. Since the method on Module is
> "setDataLayout" can we make this "DataLayout" instead? I'd like
> this to
> be a bit more specific.
>
> Chris: your thoughts?
Agree, I just changed this.
>> %type <UIntVal> OptCallingConv
>>
>> // Basic Block Terminating Operators
>> @@ -1873,6 +1874,11 @@
>> free($3);
>> CHECK_FOR_ERROR
>> };
>> + | DATA '=' STRINGCONSTANT {
>> + CurModule.CurrentModule->setDataLayout($3);
>> + free($3);
>> + CHECK_FOR_ERROR
>
> I don't think you need a CHECK_FOR_ERROR here. Neither of the two
> preceding calls will call GENERATE_ERROR.
Owen/Reid: can one of you take care of this?
Thx,
-Chris
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
