| Issue |
162392
|
| Summary |
LLVM libc used its own definition of LIBC_ASSERT in libc++
|
| Labels |
libc
|
| Assignees |
|
| Reporter |
ldionne
|
Since hand-in-hand, libc++ uses llvm-libc to implement `std::from_chars`. That's done via a "shared" layer where llvm-libc provides functions that intent to be pretty self-contained.
However, this layer includes `libc/src/__support/libc_assert.h`, which provides its own definition of `LIBC_ASSERT` based on `assert`. In libc++, we have our own assertion macro and we would like to use that instead of libc's own definition. Hence, `LIBC_ASSERT` would have to be lifted to something that can be customized by libc++ (and perhaps users generally speaking, IDK).
Does that seem fine? Do you have any preference about how to achieve that?
![]()
_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
