| Issue |
161199
|
| Summary |
LLVMConfig.cmake contains details about the host python modules
|
| Labels |
new issue
|
| Assignees |
|
| Reporter |
rossburton
|
`LLVMConfig.cmake` contains an assignment that is just specifying what Python modules were available on the build host at the time of the configure:
```
set(LLVM_HAVE_OPT_VIEWER_MODULES @LLVM_HAVE_OPT_VIEWER_MODULES@)
```
It appears that this variable is only used to control whether the opt-viewer tests in `llvm/test/tools/opt-viewer/` are executed?
This is mostly pointless:
- It is set even if opt-viewer is disabled
- If I configure llvm and then install the dependencies, it is wrong and the tests will not be ran when they should
- If I configure llvm and the uninstall the dependencies, it is wrong and the tests will fail
But also actively harmful:
- An installed file changes its contents based what python modules happen to be installed on the build machine, even if opt-viewer isn't enabled.
I propose removing this assignment from the public file, and simply running the opt-viewer tests if opt-viewer is enabled and the dependencies are present.
![]()
_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
