| Issue |
147107
|
| Summary |
[DirectX] Missing verifications of elements
|
| Labels |
backend:DirectX
|
| Assignees |
inbelic
|
| Reporter |
inbelic
|
This issue tracks resolving some discrepancies in verification during `validate` in `DXILRootSignature.cpp`.
Namely,
- `verifyDescriptorFlag` and `verifyDescriptorRangeFlag` should be updated to reflect https://github.com/llvm/wg-hlsl/pull/297
- There is currently no verification that `numDescriptors > 0` which should be added to be compliant with DXC: https://github.com/microsoft/DirectXShaderCompiler/blob/4fcf67f78f7d6ffd286316112694a3ae000860e2/lib/DxilRootSignature/DxilRootSignatureValidator.cpp#L197.
AC:
- [ ] Update `verifyDescriptorFlag` and `verifyDescriptorRangeFlag` such that they correctly reflect the validations documented
- [ ] Add `verifyNumDescriptors` to the validation of `DescriptorRange`s
![]()
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
