Issue 145814
Summary [HLSL][RootSignature] Fix formatting of puncuator Tokens in `LexHLSL`
Labels HLSL
Assignees inbelic
Reporter inbelic
    There is a bug in the diagnostic output of `ParseHLSLRootSignature` when outputting a punctuator. Instead of outputting the string literal of the token `','` it instead will treat it as an integer and output the ascii value.

Proposed solution:

Update the following switch statement to have a separate macro for `PUNCUATOR` that will output a string literal of the character as opposed to just the character.

https://github.com/llvm/llvm-project/blob/b413bea4355e51e3f3ff248b7d62b4d5d712c743/clang/include/clang/Lex/LexHLSLRootSignature.h#L46-L56

For instance: https://godbolt.org/z/vbY717qMh
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to