| Issue |
144639
|
| Summary |
[RISCV] RISCVTargetParserDef.inc doesn't get rebuilt when RISCVProcessors.td is modified
|
| Labels |
new issue
|
| Assignees |
|
| Reporter |
tclin914
|
There are a couple of post-commit CI failures (https://github.com/llvm/llvm-project/pull/144022) after we made changes to the CPU definitions.
The reason is that `RISCVTargetParserDef.inc` does not get rebuilt when `RISCVProcessors.td` is modified, because the build rule for `RISCVTargetParserDef.inc` does not declare a dependency on `RISCVProcessors.td`, as shown in `build.ninja`.
See https://github.com/llvm/llvm-project/blob/ad9e591fd53f2cf91a2744973b59669d873658af/llvm/cmake/modules/TableGen.cmake#L47 for more details.
The CMake version should be less than 3.23; otherwise, it will use depfiles (.inc.d) instead.
Should we explicitly add all the .td files under `llvm/lib/Target/RISCV/` as dependencies of `RISCVTargetParserDef.inc` , similar to `file(GLOB_RECURSE global_tds "${LLVM_MAIN_INCLUDE_DIR}/llvm/*.td")`?
![]()
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
