| Issue |
141310
|
| Summary |
[BOLT] RISCV tests rely on relocations that are not guaranteed
|
| Labels |
BOLT
|
| Assignees |
|
| Reporter |
MaskRay
|
bolt/test/RISCV tests are assembled using the default -mrelax. The generated object file contains redundant relocations, which will be removed by https://github.com/llvm/llvm-project/pull/140692
The two tests will fail unless I add back some relocations. @mtvec
```patch
diff --git a/bolt/test/RISCV/reloc-label-diff.s b/bolt/test/RISCV/reloc-label-diff.s
index 9ad38f86ff54..f1144767714b 100644
--- a/bolt/test/RISCV/reloc-label-diff.s
+++ b/bolt/test/RISCV/reloc-label-diff.s
@@ -20,4 +20,6 @@ _test_end:
.data
// CHECK: Hex dump of section '.data':
// CHECK: 0x{{.*}} 04000000
+ .reloc ., R_RISCV_ADD32, _test_end
+ .reloc ., R_RISCV_SUB32, _start
.word _test_end - _start
diff --git a/bolt/test/RISCV/reorder-blocks-reverse.s b/bolt/test/RISCV/reorder-blocks-reverse.s
index 6909fde59a48..6a9c87912827 100644
--- a/bolt/test/RISCV/reorder-blocks-reverse.s
+++ b/bolt/test/RISCV/reorder-blocks-reverse.s
@@ -7,6 +7,7 @@
.p2align 1
_start:
nop
+ .reloc ., R_RISCV_BRANCH, 1f
beq t0, t1, 1f
nop
beq t0, t2, 2f
```
![]()
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
