| Issue |
132890
|
| Summary |
[LLVM] `tools/llvm-gpu-loader` introduces silent automagic dependencies on HSA and CUDA runtimes
|
| Labels |
cmake,
llvm
|
| Assignees |
jhuber6
|
| Reporter |
mgorny
|
#132096 introduced new `llvm-gpu-loader` tool that can link to HSA and CUDA runtimes.
Both checks were added deep down the source tree, in `tools/llvm-gpu-loader/CMakeLists.txt`:
https://github.com/llvm/llvm-project/blob/bcedb368e317332d99dbdde617ebc35140b10de3/llvm/tools/llvm-gpu-loader/CMakeLists.txt#L27
https://github.com/llvm/llvm-project/blob/bcedb368e317332d99dbdde617ebc35140b10de3/llvm/tools/llvm-gpu-loader/CMakeLists.txt#L38
Neither of them features a proper `option()` to control the dependency, and on top of that, they are both marked `QUIET`, so it's **really easy** to overlook this (as we did), and end up building packages that randomly depend on either of the runtimes, or miss the specific function.
Please:
1. Do not use `QUIET` for package checks that control features included in installed tools.
2. Do not add dependency checks deep down the source tree — LLVM has a bunch of standard locations such as top `CMakeLists.txt` and `cmake/config-ix.cmake`, where people actually look for changes like these. We don't really have the resources to monitor all 528 `CMakeLists.txt` files in LLVM alone.
3. Add `option()`s to control enabling the specific dependencies, so that we can cleanly control whether they are enabled or not, rather than being automatically linked if the build system incidentally happens to have them installed.
![]()
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
