| Issue |
129940
|
| Summary |
[HLSL] Root Signature semantic analysis - Bounded Parameter checks
|
| Labels |
HLSL
|
| Assignees |
inbelic
|
| Reporter |
inbelic
|
This issue handles the additional semantic analysis of the parsed `HLSLRootSignature` attribute. This includes generating applicable diagnostics.
The relevant validations that this issue must implement are:
- [ ] Ensure valid values of `DESCRIPTOR_RANGE_FLAGS` for the `Sampler` descriptor table clause
- [ ] Ensure that listed parameters of `StaticSampler` are bounded correctly
- [ ] Validate that the `space` parameter is not in the invalid range of `0xFFFFFFF0` to `0xFFFFFFFF`
AC:
- [ ] Update `ParseHLSLRootSignature` defined in #119011 to implement semantic validation of `HLSLRootSignature`
- [ ] Update `handleHLSLRootSignature` to implement semantic validation of `HLSLRootSignature` in `SemaHLSL.cpp`
- [ ] Add thorough testing of correct diagnostics into `clang/unittests/Sema/ParseHLSLRootSignatureTest.cpp`
- [ ] Add tests for some samples to ensure diagnostics are displayed correctly from HLSL input in `AST/HLSL/RootSignatures-AST.hlsl`
![]()
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
