| Issue |
123121
|
| Summary |
Audit/Update `select` uses in DiagnosticXKinds.td to use `enum_select`.
|
| Labels |
good first issue,
clang:diagnostics
|
| Assignees |
|
| Reporter |
erichkeane
|
`enum_select` was added in this patch here: https://github.com/llvm/llvm-project/pull/122505
It is a really useful version of `select` that also creates an `enum` so that we don't have to use unreliable 'magic numbers'. However, the original patch touches one such diagnostic.
We need someone to audit all of our uses of `select` and see if:
1- the `select` has a significant number of `items` in it.
2- A lot of the uses of the `select` for the diagnostic in the source use a lot of magic numbers, OR an enum-made-just-for it
So if the diagnostic tends to have a lot of `/* ThingIWantSelected */ 5` sort of things (or worse, just the `5`!), it is likely a good candidate. Ones that are 'calculated' based on some other criteria aren't a great.
One such example is from: https://github.com/llvm/llvm-project/pull/120327 , which is what encouraged this patch.
Once we have ones identified, someone should then go through and convert these diagnostics.
![]()
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
