| Issue |
95300
|
| Summary |
clang/lib/Lex/PPDirectives.cpp:3765:43: style: Redundant condition
|
| Labels |
clang,
code-quality
|
| Assignees |
|
| Reporter |
dcb314
|
Static analyser cppcheck says:
clang/lib/Lex/PPDirectives.cpp:3765:43: style: Redundant condition: !WaitingForInnerCloseParen. 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition]
Source code is
while (CurTok.isNot(tok::eod) &&
(WaitingForInnerCloseParen ||
(!WaitingForInnerCloseParen && CurTok.isNot(tok::r_paren)))) {
Maybe better code:
while (CurTok.isNot(tok::eod) &&
(WaitingForInnerCloseParen ||
CurTok.isNot(tok::r_paren))) {
![]()
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs
